<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109814/">http://git.reviewboard.kde.org/r/109814/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2013, 10:18 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Qt 4.8 seems like it was released 1.5 years ago, if we need it for a feature I don't see why we should not increase the requirement</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree. Even RHEL 6.2 seems to be able to build Qt 4.8, so it doesn't seem like a severe requirement for KDE 4.11.</pre>
<br />
<p>- Michael</p>
<br />
<p>On April 1st, 2013, 6:41 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated April 1, 2013, 6:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://git.reviewboard.kde.org/r/109784/ requires a Qt 4.8 feature
Though kdelibs/CMakeLists.txt in 4.10 already has >>set (QT_MIN_VERSION "4.8.0")<< kde-workspace atm. requires 4.9.4 which does have that requirement.
So this boils down to the question whether
a) kde-workspace 4.11 (or just git master) on kdelibs 4.9.x is actually a concern.
b) this would expose any downstream version gap (ie. shipping Qt 4.7 and KDE 4.9 but you want to compile workspace master)
eg. debian stable has Qt 4.6 (not supported, we already require 4.7) while testing has 4.8 - so there's no issue.
Ubuntu ships KDE 4.8 on Precise and 4.9 on Quantal (latter alongside Qt 4.8)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(06b779b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>