<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109748/">http://git.reviewboard.kde.org/r/109748/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 21826b84c194e19da22bc52cfb6a4512442db11c by Thomas Fischer to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 26th, 2013, 8:18 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated March 26, 2013, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, if you make a sftp connection through the kio slave, this slave shows port number 0 to the user in the status bar (and as debug output) instead of the ssh port number 22. This is purely an UI issue, as internally the port number is tested on >0 using the default port number as a fall back if the test fails.
The attached patch address this issue by testing for port number 0. If the port number is invalid, the default port number is shown instead.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(f493477)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109748/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>