<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109675/">http://git.reviewboard.kde.org/r/109675/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the idea, but I would prefer using @SHARE_INSTALL_PREFIX@ instead of `kde4-config --prefix` (including in the existing line of code).
startkde.cmake is already pre-processed to replace such vars with their value, which makes this faster at runtime, and removes a dependency on kde4-config (in preparation for KF5).</pre>
<br />
<p>- David</p>
<br />
<p>On March 23rd, 2013, 6:37 p.m. UTC, Andreas Hartmetz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Vishesh Handa.</div>
<div>By Andreas Hartmetz.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 6:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Planned commit message:
Make sure that the KDE prefix comes first in XDG_DATA_DIRS.
I tracked down a Nepomuk problem to this. Nepomuk file indexing didn't
work because the ontologies were too old. Nepomuk loaded ontologies
from /usr/share instead of my KDE prefix /opt/kde4/share, because
/opt/kde4 was the very last entry in the respective search list in
KStandardDirs. The first entries in that search list all came from
XDG_DATA_DIRS, which in my case (Kubuntu) is set by the X session
initialization scripts. That is before startkde runs, so startkde
never touched XDG_DATA_DIRS. But it should, and now it does.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde.cmake <span style="color: grey">(8361fe0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109675/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>