<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109568/">http://git.reviewboard.kde.org/r/109568/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 22nd, 2013, 6:20 a.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You need to increase attica version and make kdelibs depends against it.
Otherwise it will not compile.
We can't depends against git master version, we must have a official release
regards.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, yes. So, I would increase attica's version from 0.4.1 to 0.4.2 and make kdelibs master depend on that?</pre>
<br />
<p>- Sven</p>
<br />
<p>On March 18th, 2013, 5:41 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Attica, kdelibs and Jeremy Paul Whiting.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 5:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account.
This patch depends on https://git.reviewboard.kde.org/r/109567/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>knewstuff/knewstuff3/uploaddialog.h <span style="color: grey">(3f58f7d)</span></li>
<li>knewstuff/knewstuff3/uploaddialog.cpp <span style="color: grey">(922469e)</span></li>
<li>knewstuff/knewstuff3/uploaddialog.ui <span style="color: grey">(aa54d2b)</span></li>
<li>knewstuff/knewstuff3/uploaddialog_p.h <span style="color: grey">(1bb0af4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>