<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107716/">http://git.reviewboard.kde.org/r/107716/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Albert</p>


<br />
<p>On March 11th, 2013, 3:16 a.m. UTC, Aleix Pol Gonzalez wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated March 11, 2013, 3:16 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes the generated code so that if a property is "UrlList" in the kcfg file, the variable that will receive it when generating the skeleton is a KUrl::List instead a QStringList. This solves the following compiling error:

aleix@kubuntu:~/projects/muon/build$ make
[  0%] Built target muonprivate_automoc
[  0%] Building CXX object libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o
In file included from /usr/include/kcoreconfigskeleton.h:28:0,
                 from /usr/include/kconfigskeleton.h:28,
                 from /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8,
                 from /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4:
/usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()’:
/usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const’ is private
/home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: within this context
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(493c7d1)</span></li>

 <li>kdeui/tests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(28e916f)</span></li>

 <li>kdeui/tests/kconfig_compiler/test12.cpp.ref <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeui/tests/kconfig_compiler/test12.h.ref <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeui/tests/kconfig_compiler/test12.kcfg <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeui/tests/kconfig_compiler/test12.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kdeui/tests/kconfig_compiler/test12main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107716/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>