<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109421/">http://git.reviewboard.kde.org/r/109421/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Jeremy Paul Whiting.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 11:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The download dialog correctly takes a custom providers .xml file,
as can be specified in the .knsrc file, into account; however the
upload dialog just ignored this option until now. This patch
intends to fix that behavior.
Nothing should change if you don't have a custom ProvidersUrl= in your
.knsrc file.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new provider is correctly being listed in the dropdown list of the first page of the dialog. If the custom provider is selected, the program tries to establish a connection to that provider. However, I could not test it any further because I don't have a working provider server... yet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>knewstuff/knewstuff3/upload/atticahelper.h <span style="color: grey">(4e538d3)</span></li>
<li>knewstuff/knewstuff3/upload/atticahelper.cpp <span style="color: grey">(735910f)</span></li>
<li>knewstuff/knewstuff3/uploaddialog.cpp <span style="color: grey">(70a8568)</span></li>
<li>knewstuff/knewstuff3/uploaddialog_p.h <span style="color: grey">(50f8dd9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109421/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/11/newdialog1.png">a screenshot of the dialog showing two providers, one of them loaded from the XML file specified in .knsrc</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>