<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103682/">http://git.reviewboard.kde.org/r/103682/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 30th, 2012, 4:09 p.m. CEST, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been submitted?</pre>
</blockquote>
<p>On April 30th, 2012, 4:28 p.m. CEST, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I did not get any feedback from maintainers. Not sure if it still makes sense, because Dolphin 4.9 gets a new places panel, not based on KFilePlacesView. The patch probably also does not fix the spin-up behavior, because that seems to be caused by Solid's icon determination code, according to comments in mentioned bug reports.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess this can be closed now; the spin-up misbehavior is fixed in Solid/udisks2 and Dolphin has different code as you said</pre>
<br />
<p>- Lukáš</p>
<br />
<p>On January 12th, 2012, 5:42 p.m. CET, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, kdelibs and Solid.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I only tried to fix the double/blurry text (bug 248062), but stumbled upon a possible reason for the unwanted spin-up behavior reported in the other bugs. According to the code, the KFreeDiskSpaceInfo object is queried even if we do not display the capacity bar.
The attached patch should fix it:
- the text is not faded at two positions, but moved between those two positions
- the KFreeDiskSpaceInfo object is only created if we indeed want to show the capacity bar
I tried to separate the patches for those two issues, but it was not possible.
Please review.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=184449">184449</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=248062">248062</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=261552">261552</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=264487">264487</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=268103">268103</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplacesview.cpp <span style="color: grey">(6a343b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103682/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>