<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107409/">http://git.reviewboard.kde.org/r/107409/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107409/diff/5/?file=111140#file111140line1562" style="color: black; font-weight: bold; text-decoration: underline;">kmenuedit/treeview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1561</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">TreeView</span><span class="o">::</span><span class="n">sortItemChildren</span><span class="p">(</span><span class="k">const</span> <span class="n">QList</span><span class="o"><</span><span class="n">QTreeWidgetItem</span><span class="o">*>::</span><span class="n">iterator</span><span class="o">&</span> <span class="n">begin</span><span class="p">,</span> <span class="k">const</span> <span class="n">QList</span><span class="o"><</span><span class="n">QTreeWidgetItem</span><span class="o">*>::</span><span class="n">iterator</span><span class="o">&</span> <span class="n">end</span><span class="p">,</span> <span class="k">const</spa
n> <span class="n">SortType</span><span class="o">&</span> <span class="n">sortType</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we need all this new function for the "Use name if description is empty" thing? Wouldn't it be easier to just make itemDescriptionLessThan call itemNameLessThan if both descriptions are emtpy?</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On January 30th, 2013, 10:40 p.m. UTC, Julien Borderie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Albert Astals Cid.</div>
<div>By Julien Borderie.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2013, 10:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
This patch adds 2 actions to sort items in KMenuEdit (by name or description) :
- sort sub-elements for the current selection.
- sort all elements.
Particularities :
- It respects separator elements to avoid mixing elements groups together.
- Actions are available in the main menu, toolbar and contextual menu.
- Once saved, changes also visible in the K menu.
- Recursive sort.
- Selection sorting is disabled if the selection is empty or is not a menu.
Thank you for your review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If started KMenuEdit does not make part of the running KDE version, these following test cases require to make a kbuildsycoca4 to be visible in the current K menu.
1) Sort element by name
- Select an element
- Choose "sort by name" --> item children sorted
- Now save (and kbuildsycoca4) --> kmenu displays sorted children
2) Sort element by description
- Select an element
- Choose "sort by description" --> item children sorted
- Now save (and kbuildsycoca4) --> kmenu displays sorted children
3) Sort all by name
- Choose "sort all by name" --> all items sorted
- Now save (and kbuildsycoca4) --> kmenu displays sorted items
4) Sort all by description
- Choose "sort all by description" --> all items sorted
- Now save (and kbuildsycoca4) --> kmenu displays sorted items</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=108419">108419</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmenuedit/treeview.h <span style="color: grey">(0284584)</span></li>
<li>kmenuedit/main.cpp <span style="color: grey">(65efdf9)</span></li>
<li>kmenuedit/kmenueditui.rc <span style="color: grey">(273847d)</span></li>
<li>kmenuedit/kmenuedit.cpp <span style="color: grey">(6a0506b)</span></li>
<li>kmenuedit/treeview.cpp <span style="color: grey">(b144b1c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107409/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>