<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108875/">http://git.reviewboard.kde.org/r/108875/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108875/diff/4/?file=113356#file113356line12" style="color: black; font-weight: bold; text-decoration: underline;">staging/sonnet/src/core/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">kconfig_SOURCE_DIR</span><span class="o">}</span><span class="s">/src/core</span> <span class="c"># ksharedptr.h, used by kservice</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span class="nv">kconfig_SOURCE_DIR</span><span class="o">}</span><span class="s">/src/core</span> <span class="c"># ksharedptr.h, used by kservice</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove comment about kservice, or remove kconfig dependency altogether if now unused</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On February 9th, 2013, 6:30 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2013, 6:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port Sonnet to use QPluginLoader instead of KServiceTypeTrader/KPluginLoader.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/sonnet/src/core/CMakeLists.txt <span style="color: grey">(fcbbbe1)</span></li>
<li>staging/sonnet/src/core/loader.cpp <span style="color: grey">(bd64e2a)</span></li>
<li>staging/sonnet/src/core/loader_p.h <span style="color: grey">(896a8f8)</span></li>
<li>staging/sonnet/src/plugins/aspell/CMakeLists.txt <span style="color: grey">(2f7c4bd)</span></li>
<li>staging/sonnet/src/plugins/aspell/kspell_aspell.desktop <span style="color: grey">(aa22c1b)</span></li>
<li>staging/sonnet/src/plugins/enchant/CMakeLists.txt <span style="color: grey">(e3365cf)</span></li>
<li>staging/sonnet/src/plugins/enchant/kspell_enchant.desktop <span style="color: grey">(4cee638)</span></li>
<li>staging/sonnet/src/plugins/hspell/CMakeLists.txt <span style="color: grey">(9e7bf13)</span></li>
<li>staging/sonnet/src/plugins/hspell/kspell_hspell.desktop <span style="color: grey">(929e843)</span></li>
<li>staging/sonnet/src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(3f8a30c)</span></li>
<li>staging/sonnet/src/plugins/hunspell/kspell_hunspell.desktop <span style="color: grey">(94ea5ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108875/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>