<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108541/">http://git.reviewboard.kde.org/r/108541/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If some code from drkonqi is needed in kbugreport, feel free to copy it, make it a public method in kbugreport, and call that from drkonqi once it requires the kdelibs version that has the code (thus getting rid of the code duplication at that point).</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108541/diff/1/?file=108577#file108577line329" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kbugreport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KBugReport::setMessageBody(const QString &messageBody)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">329</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">url</span><span class="p">.</span><span class="n">addQueryItem</span><span class="p">(</span> <span class="s">"kdeVersion"</span><span class="p">,</span> <span class="n">kde_version</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">329</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// the string format is product/component, where component is optinal</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">optinal -> optional</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On January 22nd, 2013, 11:09 a.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Ben Cooksley.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2013, 11:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently kbugreport just can't fill platform information. There are two reasons:
1. kbugreport currently pass the results of uname, while bugs.kde.org expects a few
predefined values like "Gentoo packages", "Chakra", "Ubuntu packages", etc.
2. even if kbugreport passes those expected values, wizard.cgi in its current form doesn't correctly redirect those info to enter_bugs.cgi, since the latter expects and understands "sys_os" and "rep_platform" fields, instead of the "additional_info" field.
According to this commit[1], the home-made wizard.cgi exists solely for the sake of compatibility. So I wouldn't expect any one has the motivation to improve wizard.cgi.
This patch makes kbugreport interact with enter_bug.cgi directly. It doesn't really improve anything, but it comes as preparation for further work. There is no functionality lost, since the feature of filling platform information has been broken for a long time.
Side note: As written in the TODO, I would like to make kbugreport correctly fill OS and Platform information. The plan is stupid, just reuse/copy the systeminformation.cpp[2] from drkonqi, which does a good job in guessing OS and Platform for drkonqi. But I don't know whether such code duplication is allowed or will interfere with the frameworks .
[1] http://commits.kde.org/websites/bugs-kde-org/491ded267e43faa79723fd31a9b64dd266a6f932
[2] https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/drkonqi/systeminformation.cpp
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291346">291346</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kbugreport.cpp <span style="color: grey">(2e72828)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108541/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>