<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108367/">http://git.reviewboard.kde.org/r/108367/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 26th, 2013, 3:13 a.m. UTC, <b>Andriy Rysin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manuel, I like how it looks in general with rounded corners and space between keys, but I must say that the font size is quite small. E.g. small letters are not easy to read even with good eyes, I wander if there's a way to reach the size of the preview you need without sacrificing readability. I also think that without 3rd/4th level it would be more readable but with 4 symbols in a square of this size it gets too crowded.
Also I am not sure if white vs lightblue provides enough differentiation between the levels. I wander if the key size is larger that would be a less of a problem.
Another thing is I am not sure we should just hardcode the font and size (although the size is hardcoded in original code). I wonder if we should calculate the key size and font size based on the preview window size. Start with something small to be able to fit smaller screens but if user wants to zoom in, he can just resize/maximize preview window and see larger picture.
On for the Weng's comment: I agree, hardcoded geometry is not good, we plan to parse geometry from xkb for next version, but I am not sure if Weng's code would be used. For keyboard layout preview we need to have a geometry from kcm UI which may not be applied yet, so we can't use active geometry. Although that might not be that big of a problem if we actually do use active one (if user switches keyboard model he would just have to apply before opening layout preview).</pre>
</blockquote>
<p>On January 26th, 2013, 9:41 a.m. UTC, <b>Manuel Tortosa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The preview you are seeing is exactly this: http://wstaw.org/m/2013/01/13/tribe55.jpg cannot be bigger as it is part of an installer and thus, should fit on 1024x768 ( also the blue color is just a visual change to fit more into my installer), the size is really easy to change.
About hardcodding the font and size, the font and size it is already hardcodded in the current code, in fact quite more hardcodded in the current one. I agree about parsing the model and geometry etc but maybe you can extract some interesant parts.
If you like i can apply some little parts like paintKey and paintLabeledKey which are already abstracted.
</pre>
</blockquote>
<p>On January 26th, 2013, 10:07 a.m. UTC, <b>Manuel Tortosa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, also you should consider to re-thnk the number of symbols used on each key: http://wstaw.org/m/2013/01/26/keyboard.jpg that's German Keyboard - model Neo2</pre>
</blockquote>
<p>On January 27th, 2013, 1:05 a.m. UTC, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You don't need to worry about that, it can parse any geometry even it's not active. My code can already do this.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reg. too small fonts: scale the key when hovering with the mouse? (or select / press it?)
What about altering the text position/sizes when a modifier is pressed?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On January 12th, 2013, 5:13 p.m. UTC, Manuel Tortosa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Manuel Tortosa.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2013, 5:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am working in a keyboard preview widget, based on kcontrol's one, for the Chakra Project's installer. If you are interested i can create a patch so it may replace the KDE one.
This one is 768x292 (the one in kcontrol is 1300+ wide, not suitable for lower resolutions), and it is almost done (i need to center the Ctrl, Alt and ALtGr texts using QTextMetric or whatever).
If you are interested i can create the patch, the relevant files are kbpreviewframe.cpp+h, the current code (need clean, etc) it is located here:
http://gitorious.org/chakra/tribe/blobs/info/src/widgets/kbpreview/kbpreviewframe.cpp
http://gitorious.org/chakra/tribe/blobs/info/src/widgets/kbpreview/kbpreviewframe.h
The change is kinda big and it is my first attempt to create something with Qt so i prefer to wait some ideas before actually create the relevant patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically i have tested it in our installer and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108367/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/12/before.png">before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/12/after.jpg">after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>