<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108277/">http://git.reviewboard.kde.org/r/108277/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 99175ed16914d4a1e1028b9dadb4fd01fc29b446 by David Faure to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 8th, 2013, 8:40 p.m., David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Dawit Alemayehu.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 8:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rework fix for bug 279675 so that the new mimetype is used by KRun too.
When the mimetype has to be refined from the url-filename or suggested-filename,
it's not enough to show the user, we have to also pass it on to the application
and to KRun. Otherwise clicking "open with KWrite" can end up not doing anything,
due to the service->hasMimeType() check in KRun. It also didn't benefit from
the turning of shellscript into text/plain in BrowserRun::handleNonEmbeddable
since the mimetype fixup was done afterwards.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opening a "foo.sh" attachment on roundcube (which sends application/octet-stream as mimetype).
It offered "open with kwrite" but choosing that would lead to an open-with dialog, because the mimetype was still application/octet-stream in KRun.
With this fix, kwrite runs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279675">279675</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kparts/browseropenorsavequestion.cpp <span style="color: grey">(3b7ad0bf52137f44c736f7758399e718279f6bd1)</span></li>
<li>kparts/browserrun.cpp <span style="color: grey">(6de0380a04b58ff72c4cdd89dc18ccbabde9c629)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108277/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>