<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108328/">http://git.reviewboard.kde.org/r/108328/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 10th, 2013, 11:47 p.m., <b>Chao Feng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/r/108328/s/1015/" style="color: black; font-weight: bold; font-size: 9pt;">systemsettings2.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/108328/s/1015/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings2_331_229_107_105.png" style="border: 1px black solid;" alt="chinese after change"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Others looks good, I still think here it looks strange. Increase to 7 characters?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Increase to 7 characters will only make 8 the number of characters in the text that looks strange. (and in fact it is 7 characters with my font settings.)
This should be a different issue that may be solved by changing how word wrapping is done for short Chinese text in Qt instead of disabling word wrapping or increasing the limit to a magic value IMHO.
</pre>
<br />
<p>- Yichao</p>
<br />
<p>On January 10th, 2013, 8:48 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, and Yichao Yu.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 8:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set minimum width for system settings icon view item depending on font. Since KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that can have a minimumSize. (Maybe should be add to kdelibs in the future?)
This fontHeight * 6 heuristic value works for all languages. CJK character is usually square (width = height) so this roughly means 6 CJK character, and 12 latin letter (height = width * 2), which will always look good.
To fengchao, I'm sorry if you feel I steal your job.. but I can't stop myself since I think I can fix it in 10 minutes..</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see screenshot.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=234407">234407</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>systemsettings/icons/CMakeLists.txt <span style="color: grey">(0830dd7)</span></li>
<li>systemsettings/icons/FileItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>systemsettings/icons/FileItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>systemsettings/icons/IconMode.cpp <span style="color: grey">(37cfc4b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108328/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108328/s/1014/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings1_400x100.png" style="border: 1px black solid;" alt="english after change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1015/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings2_400x100.png" style="border: 1px black solid;" alt="chinese after change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1016/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings3_400x100.png" style="border: 1px black solid;" alt="chinese before change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1017/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings4_400x100.png" style="border: 1px black solid;" alt="spanish after change" /></a>
<a href="http://git.reviewboard.kde.org/r/108328/s/1023/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/systemsettings5_400x100.png" style="border: 1px black solid;" alt="spanish before change" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>