<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108246/">http://git.reviewboard.kde.org/r/108246/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2013, 6:30 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Evil: do you think you could provide a test? Seems like if you already have an image that files, maybe it wouldn't be that hard?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be done, but I don't know where to put such tests: there is khtml/test/ but this contains only a few html files, images and a README which says not to add anything there. There is also khtml/tests/ which contains one unittest: khtmlparttest, but this is about testing instantiation of the KHTMLPart class. Is there a set of unit tests to check KHTML rendering?</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On January 7th, 2013, 6:16 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Martin Tobias Holmedahl Sandsmark and Maks Orlovich.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 6:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code in scaledLoop32bit() has an off-by-one error in computation of the versions index, causing some images to contain garbage on their last line. This is visible in Konqueror and Akregator intro pages.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested Akregator and Konqueror about pages. Browsed a few websites with Konqueror + KHTML.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/imload/scaledimageplane.cpp <span style="color: grey">(e8ab684)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108246/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108246/s/988/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/07/konq_400x100.png" style="border: 1px black solid;" alt="Konqueror, before - after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>