<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108243/">http://git.reviewboard.kde.org/r/108243/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need to think about whether I want to have it in org.kde.kwin.tabbox or org.kde.kwin. Even if the QML scripts work with Plasma.Dialog I'm not sure whether we should continue to use it or better have our own component which uses the background (and some other KWin specific adjustments). I just don't like the thought of KWin communicating with KWin through X :-) For 4.10 it shall be Plasma.Dialog there of course.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108243/diff/2/?file=105557#file105557line2" style="color: black; font-weight: bold; text-decoration: underline;">kwin/tabbox/qml/qmldir</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">IconTabBox 0.1 IconTabBox.qml</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please don't include the IconTabBox in the qmldir. I consider it private API :-)</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On January 7th, 2013, 4:07 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, Marco Martin, and Martin Gräßlin.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 4:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a different solution solve problem in https://git.reviewboard.kde.org/r/108224/
1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(3bdcfac)</span></li>
<li>kwin/tabbox/qml/CMakeLists.txt <span style="color: grey">(d4bc863)</span></li>
<li>kwin/tabbox/qml/IconTabBox.qml <span style="color: grey">(23bb11b)</span></li>
<li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: grey">(7115b7f)</span></li>
<li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: grey">(1f6f036)</span></li>
<li>kwin/tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: grey">(3a2c4a3)</span></li>
<li>kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: grey">(14a54d3)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: grey">(ea09ed0)</span></li>
<li>kwin/tabbox/qml/clients/text/contents/ui/main.qml <span style="color: grey">(c0def27)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: grey">(efe3ebe)</span></li>
<li>kwin/tabbox/qml/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/tabbox.qml <span style="color: grey">(4176231)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108243/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>