<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107970/">http://git.reviewboard.kde.org/r/107970/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d21088dbd106940b515ebc736cd9ad286ff7f5fd by Jekyll Wu on behalf of Arnav Singh to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 28th, 2012, 3:50 a.m., Arnav Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Arnav Singh.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 3:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've added support for sensor displays in KSysGuard to have row spans and column spans.
Apart from adding rowSpan and columnSpan arguments to the method signatures, I've also removed the internal list (WorkSheet::mDisplayList) used to contain all the sensor displays. This list used to be used to derived the row and column of the displays based on their index in the list. Since I now need to maintain rowSpan and columnSpan information as well, I just removed the list entirely and get all my data from mGridLayout. As a result, another change in the method signatures is the replacement of the "index" parameter with "row" and "column" parameters.
An extra advantage of doing it this way is that widgets don't shift around when resizing the grid. Another advantage is that blank spaces between the widgets are now possible. Not to mention, not maintaining the layout information outside of the actual layout component (mGridLayout) seems a clearer design to me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on 4.9.4</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311925">311925</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksysguard/gui/WorkSheet.h <span style="color: grey">(9f4806d)</span></li>
<li>ksysguard/gui/WorkSheet.cpp <span style="color: grey">(b20f077)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107970/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107970/s/936/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/28/snapshot1_400x100.png" style="border: 1px black solid;" alt="Example" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>