<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107775/">http://git.reviewboard.kde.org/r/107775/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107775/diff/1/?file=99903#file99903line133" style="color: black; font-weight: bold; text-decoration: underline;">drkonqi/drkonqidialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DrKonqiDialog::buildMainWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">133</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">"</para>"</span><span class="p">,</span> <span class="n">crashedApp</span><span class="o">-></span><span class="n">executable</span><span class="p">().</span><span class="n">fileName</span><span class="p">(),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">133</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">"<span class="hl">Time: %5 %6</span></para>"</span><span class="p">,</span> <span class="n">crashedApp</span><span class="o">-></span><span class="n">executable</span><span class="p">().</span><span class="n">fileName</span><span class="p">(),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am slightly worried about "<date> <time>" being in this fixed order and without any proper context for the translators. I'd at least put some context about %5 and %6 in the context comment ("@info").</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from that, everything else is fine.</pre>
<p>- George</p>
<br />
<p>On December 17th, 2012, 11 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and George Kiagiadakis.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2012, 11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces two changes:
1. show the crash time in the bottom of the "General" tab
2. use the remembered crash time instead of the current time as part of the suggested file name when saving the backtrace .</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309330">309330</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/crashedapplication.h <span style="color: grey">(403457d)</span></li>
<li>drkonqi/crashedapplication.cpp <span style="color: grey">(67ca58e)</span></li>
<li>drkonqi/drkonqi.cpp <span style="color: grey">(e1d6222)</span></li>
<li>drkonqi/drkonqibackends.cpp <span style="color: grey">(59f3b35)</span></li>
<li>drkonqi/drkonqidialog.cpp <span style="color: grey">(141679b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107775/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107775/s/905/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/17/drkonqi-crash-time_400x100.png" style="border: 1px black solid;" alt="show crash in "General" tab" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>