<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107421/">http://git.reviewboard.kde.org/r/107421/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 22nd, 2012, 7:45 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This probably needs a #ifdef on the kdelibs version number, then, since apparently kde-baseapps master only requires kdelibs-4.8...
It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, but that wouldn't help anyway.
</pre>
</blockquote>
<p>On November 22nd, 2012, 9:30 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because when i sent an email to k-c-d with "Dependency Freeze for 4.10 in two weeks" asking for depencies like that to be increased noone suggested changing it
</pre>
</blockquote>
<p>On November 22nd, 2012, 10:02 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Dawit for implementing this!
About the kdelibs version issue: wouldn't the easiest solution be to raise the version requirement once master is open again and push the patch to master then? It won't hurt much if the KIO::SlaveConfig call stays in the 4.10 branch, right?</pre>
</blockquote>
<p>On November 22nd, 2012, 10:20 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds like a plan.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the record I did raise my hand in response to your k-c-d post Albert. kde-baseapps in the 4.10 branch REQUIRES a minimum of kdelibs v4.9.80 to work correctly. Otherwise, cookie handling will be completely screwed up if the user launches the cookie configuration dialog. Based on the conversion in the thread you created, I personally did change the KDE_MIN_VERSION flag to 4.9.80, but I did not do anything to the KDE4 flag because I did not know I was supposed to update that too. :( It still would be safe to update KDE4 to the correct version since people won't be able to compile kde-baseapps against any kdelibs version older than v4.9.80 right now, no ?
Anyhow, there is no reason to rush this into the 4.10 branch ; so waiting for master to open and the pushing it there indeed sounds like a plan.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On November 22nd, 2012, 5:26 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Frank Reininghaus.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 5:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch ports Dolphin away from using KIO::SlaveConfig::configData into the newly added KProtocolManager::charsetFor API. KIO::SlaveConfig was never intended to be a public class and as such it is going to go away in KF5.
Please note that you need to latest kdelibs from the 4.10 branch in order to compile this change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinremoteencoding.cpp <span style="color: grey">(375b3fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107421/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>