<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107332/">http://git.reviewboard.kde.org/r/107332/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good catch, things looks more aligned now.
I am a bit worried about the 2px value being specific to Oxygen widget style though. How does it behave with other styles? Maybe you can extract this value using QStyle::pixelMetric(QStyle::PM_DefaultFrameWidth)?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107332/diff/1/?file=94835#file94835line42" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/kmessagewidgettest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char* argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">frame</span><span class="o">-></span><span class="n">setFrameStyle</span><span class="p">(</span><span class="n">QFrame</span><span class="o">::</span><span class="n">Panel</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">frame</span><span class="o">-></span><span class="n">setFrameStyle</span><span class="p">(</span><span class="n">QFrame</span><span class="o">::</span><span class="n"><span class="hl">Styled</span>Panel</span><span class="hl"> </span><span class="o"><span class="hl">|</span></span><span class="hl"> </span><span class="n"><span class="hl">QFrame</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Sunken</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am actually wondering whether the setFrameStyle() call is needed at all. Do you get a different result without it?</pre>
</div>
<br />
<p>- Aurélien</p>
<br />
<p>On November 15th, 2012, 6:40 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Aurélien Gâteau.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2012, 6:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix margin on KMessageWidget to match that used by a styled QFrame.
The rationale being that in almost every usage of KMessageWidget it's used above a sunken QFrame (kate, kmail, dolphin)
currently the message widget is slight wider, which looks wrong.
Updated testing code to match the more common usage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screenshot shows the difference, look at left hand side of message widget lining up with the frame below.
Also opened in Kate, KMail, Bluetooth KCM, ktp-accounts-kcm. All instances lined up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kmessagewidgettest.cpp <span style="color: grey">(be517fce802a8594a6d4aae50f0d1c8955d3cbf2)</span></li>
<li>kdeui/widgets/kmessagewidget.cpp <span style="color: grey">(b87b3e49e9824c068bd1d85ac7ecb2de337fa86b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107332/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107332/s/833/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/15/kmessage-widget2_400x100.png" style="border: 1px black solid;" alt="Original KMessageWidget (left) and improved KMessageWidget (right)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>