<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107023/">http://git.reviewboard.kde.org/r/107023/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">works for me :)</pre>
<br />
<p>- Milian</p>
<br />
<p>On October 24th, 2012, 3:46 p.m., Dominik Haumann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2012, 3:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDE applications support the option: --geometry <width>x<height>{+-}<xpos>{+-}<ypos>
Example: kwrite --geometry 800x600+100+100
While the width and height arguments work, the x/y positions only work if they are negative. The code was added 11 years ago with commit d3188ee411df716b20e10fcdaa9dbc506cc31759 and probably never worked. This patch tries to fix it.
In KDE 5, support for --geometry was removed with commit fbc835090758581ba57ffbd210c00e60b1e1742f in the frameworks branch. Still having a working version for the KDE 4 lifetime would be nice imo :-)
Related bug reports: https://bugs.kde.org/show_bug.cgi?id=147094</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not tested, since I have no KDE4 kdelibs build. It's very much appreciated, if someone else can test this.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165355">165355</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=304279">304279</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kmainwindow.cpp <span style="color: grey">(86ccab8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107023/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>