<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106755/">http://git.reviewboard.kde.org/r/106755/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2012, 9:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Accepted that the /dev/XXXX name is technical information and usually not useful to the user. However, the mount point is (especially in the case of needing to access the device from non-KDE applications); most distros are standardised on /media/LABEL now but, even if the user knows that, the device label is nowhere currently available in the GUI.
The updated patch shows a tool tip over the device label. It can say one of:
Not mounted
Mounted on /media/YYYY
Mounted
It could be argued that the word "mount" is technical jargon and should not be used, but I can't think of a suitable alternative (and "mount" is the term used elsewhere).
Agreed that the best resolution for "can't unmount" would be to show applications or processes that are blocking the mount, but implementing that is not trivial (as discussed in bug 96107).
Not convinced that the place to find this information is another Properties dialogue, especially if it it necessary to open or go to another application - in this case the user may as well open a terminal window and type 'df' or 'mount'...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a removable device is mounted using the Plasma device notifier, there is no indication of what the Unix name of the device is or where it is mounted. This information may be useful to the user for (a) accessing the mounted device from non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
The attached patch shows this information when the device is hovered over, just above the "N actions for this device" text. Depending on whether or not the device is mounted, there are three possibilities that can be shown here:
/dev/XXX when not mounted
/dev/XXX mounted on /media/YYYY when mounted
/dev/XXX mounted if mounted but the mount point is not available
Please be gentle, this is my first QML patch :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built kde-workspace with this change, observed operation and display of device notifier with a selection of removable devices.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=196939">196939</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span style="color: grey">(396de2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106755/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106755/s/756/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/07/196939_400x100.png" style="border: 1px black solid;" alt="Device notifier with mounted device" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>