<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106503/">http://git.reviewboard.kde.org/r/106503/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2012, 3:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Fixed compilation problem with previous patch.
- Reused code to set the windows group.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Unselected sessions should not be restored.
* If all available sessions are selected (the default), the behavior should remain the same as it is today.
* If all available sessions are unselected, disable the "Restore Session" button.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260282">260282</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqsessionmanager.h <span style="color: grey">(ee629e4)</span></li>
<li>konqueror/src/konqsessionmanager.cpp <span style="color: grey">(68a003f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106503/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106503/s/729/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/old_konqueror_restore_dialog_400x100.png" style="border: 1px black solid;" alt="old restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/731/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/new_konqueror_restore_dialog_1_400x100.png" style="border: 1px black solid;" alt="new restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/739/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/new_konqueror_restore_dialog_1_400x100.png" style="border: 1px black solid;" alt="new restore dialog v2" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/750/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/01/new_konqueror_restore_dialog_400x100.png" style="border: 1px black solid;" alt="new restore dialog v3" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>