<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101348/">http://git.reviewboard.kde.org/r/101348/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2011, 10:05 a.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any progress on this?
I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s "Activity" menu in the window title where you can assign a window to multiple activities.</pre>
</blockquote>
<p>On October 26th, 2011, 7:55 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unfortunately, this can't only be done in the frameworks branch, and even then not quite yet. kactivities has already been broken out, and while it should be a valid dependency for the kfile library, kdelibs is not yet broken up so it would create a circular build dependency at the moment (as kactivities relies on libkdecore).
when it does go in, however, i agree with Jeff that adding a specific activity chooser would be ungainly. it also would not fit in with the rest of this dialog which has entries like "only in this application" (rather than "in the following applications...")</pre>
</blockquote>
<p>On October 26th, 2011, 4:25 p.m., <b>Jeffery MacEachern</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for the info, Aaron. School (and life) have prevented me from doing much of anything for the last several months, so if somebody else wants to pick this up, please feel free. I don't know when I'll have time again.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we (=someone) make a frameworks branch for kactivities, it should be quite simple to port that away from kdecore (I suppose it was mostly using KPluginLoader, which has now moved to the kservice framework). So this might just be a matter of updating a few CMakeLists.txt files.</pre>
<br />
<p>- David</p>
<br />
<p>On June 1st, 2011, 6:07 a.m., Jeffery MacEachern wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs, Ivan Čukić, Kevin Ottens, and David Faure.</div>
<div>By Jeffery MacEachern.</div>
<p style="color: grey;"><i>Updated June 1, 2011, 6:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds an "Only show in this Activity" option to the KFilePlaces Widget and support in the underlying model code. Currently only "one activity"/"all activities" are supported as choices; I think this should be sufficient, and anything more complicated would be hard to make usable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Project Neon/Kubuntu Natty. Created several activities, added Place bookmarks, set them to only show in the current activity, and switched activities. Everything worked as intended. EDIT: one small known issue - the OnlyInActivity setting doesn't take when the bookmark is first created; you have to hit Edit and re-check the box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/CMakeLists.txt <span style="color: grey">(ceae140)</span></li>
<li>kfile/kfileplaceeditdialog.h <span style="color: grey">(d5b030a)</span></li>
<li>kfile/kfileplaceeditdialog.cpp <span style="color: grey">(d798b4d)</span></li>
<li>kfile/kfileplacesmodel.h <span style="color: grey">(b3dd821)</span></li>
<li>kfile/kfileplacesmodel.cpp <span style="color: grey">(b037084)</span></li>
<li>kfile/kfileplacesview.cpp <span style="color: grey">(6a343b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101348/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>