<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106503/">http://git.reviewboard.kde.org/r/106503/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2012, 9:36 a.m., <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106503/diff/3/?file=87618#file87618line343" style="color: black; font-weight: bold; text-decoration: underline;">konqueror/src/konqsessionmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int showRestoreSessionDialog(QObject* object, const SessionHash& sessionList, QStringList* discardedSessionList)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">343</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="o">-></span><span class="n">setButtonGuiItem</span><span class="p">(</span><span class="n">KDialog</span><span class="o">::</span><span class="n">Yes</span><span class="p">,</span> <span class="n">KGuiItem</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"@action:button filter-yes"</span><span class="p">,</span> <span class="s">"Restore Session"</span><span class="p">),</span> <span class="s">"window-new"</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">344</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="o">-></span><span class="n">setButtonGuiItem</span><span class="p">(</span><span class="n">KDialog</span><span class="o">::</span><span class="n">No</span><span class="p">,</span> <span class="n">KGuiItem</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"@action:button filter-no"</span><span class="p">,</span><span class="s">"Do Not Restore"</span><span class="p">),</span> <span class="s">"dialog-close"</span><span class="p">));</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">345</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="o">-></span><span class="n">setButtonGuiItem</span><span class="p">(</span><span class="n">KDialog</span><span class="o">::</span><span class="n">Cancel</span><span class="p">,</span> <span class="n">KGuiItem</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"@action:button filter-cancel"</span><span class="p">,</span><span class="s">"Ask Me Later"</span><span class="p">),</span> <span class="s">"chronometer"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i18n: what do these "filter-..." contexts mean?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I copied those straight out of KMessageBox's code. Since I do not really know what they mean, I will simply remove it and use "yes", "no" and "cancel" instead.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On September 28th, 2012, 4:45 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2012, 4:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch fixes one of those pet peeve bugs that infurate me from time to time by allowing me to unselect the sessions I do not want to be restored when Konqueror's restore session dialog pops up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Unselected sessions should not be restored.
* If all available sessions are selected (the default), the behavior should remain the same as it is today.
* If all available sessions are unselected, disable the "Restore Session" button.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260282">260282</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqsessionmanager.h <span style="color: grey">(ee629e4)</span></li>
<li>konqueror/src/konqsessionmanager.cpp <span style="color: grey">(68a003f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106503/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106503/s/729/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/old_konqueror_restore_dialog_400x100.png" style="border: 1px black solid;" alt="old restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/731/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/new_konqueror_restore_dialog_1_400x100.png" style="border: 1px black solid;" alt="new restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/739/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/new_konqueror_restore_dialog_1_400x100.png" style="border: 1px black solid;" alt="new restore dialog v2" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>