<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106524/">http://git.reviewboard.kde.org/r/106524/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Jonathan Marten.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The referenced bug suggests that it should be possible to individually select screen savers that are to be considered when the "Random" option is chosen. This patch implements that.
In order to avoid having to duplicate the complete saver tree view (and the code to generate it) within the random saver's setup mode, check boxes are added to the kcontrol saver list (with the exception of the random saver itself). The state of these is saved to the random saver's config file. This selection is in addition to the two options within the saver's setup dialogue, so if for example "Use OpenGL screen savers" is not checked than any OpenGL savers will be ignored even if their boxes are checked in the tree view.
(Submitting to kde-runtime, there is no kde-workspace group)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built saver and kcontrol module with these changes. Checked operation of kcontrol module, saving of settings in the config file and operation of the random saver.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=57572">57572</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/screensaver/scrnsave.h <span style="color: grey">(7c8deba)</span></li>
<li>kcontrol/screensaver/scrnsave.cpp <span style="color: grey">(c0507d4)</span></li>
<li>kscreensaver/krandom_screensaver/random.cpp <span style="color: grey">(4047184)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106524/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106524/s/733/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/21/screensaver-random_400x100.png" style="border: 1px black solid;" alt="kcmshell4 screensaver" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>