<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106425/">http://git.reviewboard.kde.org/r/106425/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5c677ceb397de9b40a050489d1890ac6c9be17d9 by Christoph Feck to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 11th, 2012, 7:33 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Chusslove Illich.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2012, 7:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KFontAction has a constructor to filter the font list by certain criteria. When it creates a KFontComboBox to allow the user to interact with it, this box always shows all fonts.
Instead of adding a "setFontFilterCriteria()" method, I opted for adding a "setFontList()" method, for the following reasons:
- it does not have to query the Qt font database twice
- it is more flexible (you could, for example, filter by size)
@since: TBD has to be decided:
- 4.9.x, because it allows to fix bug 83212 and bug 306625
- 4.10, because it adds new API
- KF5, because it adds new API
- keep it private, only to be called by KFontAction
Note that this commit alone does NOT fix the bugs, but adds the required API.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=83212">83212</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=306625">306625</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/fonts/kfontcombobox.h <span style="color: grey">(de3cb16)</span></li>
<li>kdeui/fonts/kfontcombobox.cpp <span style="color: grey">(0ded6fb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106425/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>