<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106446/">http://git.reviewboard.kde.org/r/106446/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b856e9b9e94a96ab396662db7a503280fa267dc3 by Dawit Alemayehu to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 14th, 2012, 4:52 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2012, 4:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch fixes mount point look up failures in KAutoMount when the parition is mounted using either a LABEL or a UUID instead of the actual device name. For example, if you have the following entry in your /etc/fstab:
'LABEL="KINGSTON" /media/kingston vfat noauto,users,exec 0 0'
then mounting it will not show the device name LABEL=KINGSTON. Instead, /etc/mtab will return something like:
/dev/sdg1 on /media/kingston type vfat (rw,nosuid,nodev,relatime)
Hence, looking for a device named 'LABEL="KINGSTON"' in /etc/mtab will always result in a failure. In case of KAutoMount::slotResult, the SLOT called when mounting is finished, it prints the following warning message:
LABEL="KINGSTON" was correctly mounted, but findByDevice() didn't find it. This looks like a bug, please report it
on http://bugs.kde.org, together with your /etc/fstab and /etc/mtab lines for this device.
This patch fixes this issue by looking for the mountpoint (/media/kingston) in /etc/mtab when the device cannot be found using its device name.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Follow the description in the bug report to create a device shortcut for a mount point that uses a LABEL in /etc/fstab.
- Click on the device shortcut. The device should be mounted and the mount directory opened in a file manager.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=247235">247235</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kautomount.cpp <span style="color: grey">(9d9789d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106446/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>