<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106288/">http://git.reviewboard.kde.org/r/106288/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106288/diff/4/?file=83686#file83686line2" style="color: black; font-weight: bold; text-decoration: underline;">kparts/listingextension.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> Copyright (C) 2010 Dawit Alemayehu <adawit@kde.org></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">2010? You've been waiting for a long time to upload this file :-)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On September 4th, 2012, 7:14 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2012, 7:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch adds a new extension, ListingFilterExtension, to KParts. The main motivation for this patch is the constant breakage of the Konqueror directory filtering plugin once Konqueror was switched to use Dolphin's part for filemanagement. Because the dolphin part does not expose the same features as the implementation in the old Konqueror file management module, I had to resort to ugly hacks to make this plugin functional. Unfortunately, that hack no longer works properly because of changes/cleanup done in Dolphin's code base. Hence, this patch is an attempt to fix this issue once and for all in a manner that is clean, consistent and useful for any part that wants to provide filtering functionality. As an additional benefit this patch will also makes it very easy to add Dolphin's CTRL+I filtering feature to Konqueror.
The implementation of this extension in Dolphin can be reviewed at https://git.reviewboard.kde.org/r/106289/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kparts/listingextension.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(8a956ee)</span></li>
<li>includes/KParts/ListingExtension <span style="color: grey">(PRE-CREATION)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(96fa31f)</span></li>
<li>kparts/listingextension.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106288/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>