<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106289/">http://git.reviewboard.kde.org/r/106289/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2012, 9:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Final version. This one is thoroughly tested against both dolphin and Konqueror. In addition to fixing Konqueror's directory filter plugin, it addresses the following issues:
* Allow both name and mime-type filters to be used at the same time (aggregated filtering).
* Fix behavior of the wildcard matching support in Konqueror's location bar.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch provides an implementation of KParts' ListingFilterExtension for Dolphin. The extension allows the Dolphin KPart to provide directory/file filtering services without requiring direct linking against Dolphin itself.
The review for the new KPart listing filter extension (ListingFilterExtension) can be found at https://git.reviewboard.kde.org/r/106288/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(10f63c5)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: grey">(8050415)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelfilter.cpp <span style="color: grey">(816d356)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelfilter.h <span style="color: grey">(9bdf1fd)</span></li>
<li>dolphin/src/dolphinpart.h <span style="color: grey">(e5693b3)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(fff7dc0)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: grey">(d9bebdf)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: grey">(6936af4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106289/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>