<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106212/">http://git.reviewboard.kde.org/r/106212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2012, 11:42 a.m., <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That warning is there to remind the maintainer to re-factor that code and get rid of that message ;-)
I’d vote for using a KNotify notification: 1. the user can configure it in a way he wants to (ie. show message? play sound? run application when event occurs?) and 2. it is a passive notification that emerges from the notification area rather than a dialog popping out of nowhere with no context. FTR: I already made a patch half a year ago or so but was told there was going to be a major refactor in this area and so I left it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactor is still going on, you can checkout libkscreen repo in my scratch.
About this patch, it looks ok so feel free to ship it.</pre>
<br />
<p>- Alex</p>
<br />
<p>On August 26th, 2012, 8:40 a.m., Frederik Gladhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Alex Fiestas.</div>
<div>By Frederik Gladhorn.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dialog from the kded would show up once for each event (eg unpluggin and pluggin in again) related to monitor changes.
I wonder what the "#warning Modal dialog, stupid, fix." was supposed to fix.
The dialog was redone since it's actually not very easy to re-use KMessageBox in a non-modal way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/module/randrmonitor.h <span style="color: grey">(057c991)</span></li>
<li>kcontrol/randr/module/randrmonitor.cpp <span style="color: grey">(32d0d0a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>