<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105972/">http://git.reviewboard.kde.org/r/105972/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2012, 3:44 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105972/diff/3/?file=77712#file77712line143" style="color: black; font-weight: bold; text-decoration: underline;">dolphin/src/kitemviews/kitemlistviewaccessible.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">friend class KItemListViewAccessible;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">143</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">KItemListContainerAccessible</span> <span class="o">:</span> <span class="n">public</span> <span class="n">QAccessibleWidgetEx</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class isn't needed any more, is it?</pre>
</blockquote>
<p>On August 15th, 2012, 7:12 a.m., <b>Amandeep Singh</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class is needed since the accessibility interface tree, as is shown by Accerciser in dolphin will then never expand upto the Table Interface we wrote. Basically QAI is present for the QWidgets and a11y clients can navigate their children.
Since the KItemListView is a QGraphicsWidget, so accerciser is unable to reach it directly. The class in question, KItemListContainerA11y provides this connection to KItemListView.</pre>
</blockquote>
<p>On August 15th, 2012, 3:29 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, but then I wonder if my previous statement that the changes you had proposed in KItemListContainer in the first version of your patch are not needed is correct. I'm not familiar with QAccessible, but I can't see how any code is supposed to construct or call methods of a KItemListContainerAccessible (which is required if I understand you correctly because the QAccessible framwork cannot reach KItemListViewAccessible directly) in the current version of your patch. But maybe I got something wrong.
In other words: have you checked that the current version of the patch is still working correctly?</pre>
</blockquote>
<p>On August 21st, 2012, 9:44 a.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The way the accessible objects are constructed is in QAccessible::queryAccessibleInterface. There are factories (and this patch adds a new one for the KItemListContainerA11y and KItemListViewAccessible) that get queried. It works by using QObject introspection and comparing the class name to what the factories support.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I see. When I wrote the question above, the factory function only created a KItemListViewAccessible, not a KItemListContainerAccessible. Thanks for fixing this.</pre>
<br />
<p>- Frank</p>
<br />
<p>On August 17th, 2012, 11:20 a.m., Amandeep Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps and KDE Accessibility.</div>
<div>By Amandeep Singh.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 11:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added Accessibility Interfaces for Dolphin Views & Widgets, to make it accessible.
2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that contain the three new classes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Focus-tracking tested with KMag / KWin. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(afc190f)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: grey">(88f5d9f)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.h <span style="color: grey">(5723b9a)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.cpp <span style="color: grey">(72b3fd8)</span></li>
<li>dolphin/src/kitemviews/kitemlistviewaccessible.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/kitemlistviewaccessible.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistviewlayouter.h <span style="color: grey">(da5bd1d)</span></li>
<li>dolphin/src/tests/CMakeLists.txt <span style="color: grey">(3f906d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>