<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105984/">http://git.reviewboard.kde.org/r/105984/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 2:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This version of the patch simply defers the focus change to the location bar for a new blank tab by 500 ms. That way we give the part enough time to emit its started() signal which will put KonqView in loading state. We can then use KonqView's isLoading() function to determine whether or not we should or should not change the focus to the location bar. If the KonqView is loading we will not. Otherwise, we will assume the user created an empty tab.
Not entirely sure the use of timers is such a great idea. However, this patch most definitely resolves both bugs #304933 and #304865. It also fixes the same issue which crops up during session restore (from a crash or a system shutdown). All the aforementioned issues are caused by the simple fact that a newly created window/tab can originally have a blank url and our check relies on the URL being blank to change the focus to the location bar far too soon.
NOTE: I also went ahead and removed the redundant calls to emitActivePartChanged() in KonqViewManager::showTab function calls. That call is unnecessary because the call to KonqFrameTabs::setCurrentIndex right above it will call eventually end up calling the same function.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch address the bug reported in #304933. Right now if Konqueror is configured to open new tabs in the foreground, i.e. the "Open tabs in the background" option is unchecked, then the keyboard focus is put on the location bar instead of the view.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304865">304865</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=304933">304933</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqframe.h <span style="color: grey">(60aa4d0)</span></li>
<li>konqueror/src/konqframe.cpp <span style="color: grey">(10ed7cd)</span></li>
<li>konqueror/src/konqviewmanager.cpp <span style="color: grey">(5352eeb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>