<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105984/">http://git.reviewboard.kde.org/r/105984/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2012, 8:51 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for looking into this.
To be honest, I don't like the timer. It penalizes fast users, and it feels like a workaround. Surely at some point konqueror knows whether it's going to open a url in the tab or not. That's the point in the code where we should decide where to put the focus (and in terms of timing, this should happen almost immediately; we don't need to wait for a KonqRun or anything).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not like the timer solution either. However, short of calling setFocus() like the previous solution, I see no other way to address the problem. That is because the issue is not knowing whether we are going to open a url in the tab or not, but when. It is a timing issue as to when we should check and change the focus to the locationbar. Right now we do that in the only place that can accommodate all use cases ; both the creation of a new tab through code and the manual creation/activation of the tab by the user. Unfortunately, that is exactly the wrong place to make such a decision for the tab creation through code use case because a tab can be created with "blank" or empty URL.
The only other solution I see is to change the focus back to the view when the KPart emits the started(KIO::Job*) signal. That won't affect the manual tab activation use case and won't require timer. It does however mean adding a setFocus() call. Would that be a preferable solution ?</pre>
<br />
<p>- Dawit</p>
<br />
<p>On August 20th, 2012, 2:22 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 2:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch address the bug reported in #304933. Right now if Konqueror is configured to open new tabs in the foreground, i.e. the "Open tabs in the background" option is unchecked, then the keyboard focus is put on the location bar instead of the view.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304865">304865</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=304933">304933</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqframe.h <span style="color: grey">(60aa4d0)</span></li>
<li>konqueror/src/konqframe.cpp <span style="color: grey">(10ed7cd)</span></li>
<li>konqueror/src/konqviewmanager.cpp <span style="color: grey">(5352eeb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>