<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106052/">http://git.reviewboard.kde.org/r/106052/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 16th, 2012, 1:10 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106052/diff/1/?file=78076#file78076line92" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/jobs/kdialogjobuidelegate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KDialogJobUiDelegate::showErrorMessage()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">uint</span> <span class="n">msgBoxDisplayed</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">KMessageBox</span><span class="o">::</span><span class="n">queuedMessageBox</span> <span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">errorParentWidget</span><span class="p">,</span> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">Information</span><span class="p">,</span> <span class="n">plain</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.</pre>
</blockquote>
<p>On August 16th, 2012, 1:32 p.m., <b>Ambroz Bizjak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.</pre>
</blockquote>
<p>On August 16th, 2012, 1:43 p.m., <b>Dan Vratil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But you can get multiple kinds of warnings during the operation. How would you separate them? You would either have to have a separate dialog for each kind of error or a very complex UI dialog. In general I like the idea of a box "These files failed to copy" (similar to the Delete Files dialog), but I think that simple 'OK' would be enough. Ideas?</pre>
</blockquote>
<p>On August 16th, 2012, 2:14 p.m., <b>Ambroz Bizjak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, that's a good idea. When a file fails to copy, pop up the "These files failed to copy" dialog, but when another file fails, just add it to the list in the existing dialog. User can click "OK" which closes the dialog, and if more files fail, another one pops up. Small problem though: what happens if the user clicks OK, without noticing that another file was added to the list just before he closed the dialog? Maybe a safeguard should be added that no less than N seconds may pass from the time the last file was added to when the user clicks OK.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aggregating errors is part of Cyril Oblikov's SOC project already. I just asked him to aggregate warnings in that dialog too.
This is a longer-term fix though.</pre>
<br />
<p>- David</p>
<br />
<p>On August 16th, 2012, 12:18 p.m., Dan Vratil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2012, 12:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Display a warning when CopyJob fails to enter a subdirectory and thus can't copy it's content.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/jobs/kdialogjobuidelegate.cpp <span style="color: grey">(fe48f87)</span></li>
<li>kio/kio/copyjob.h <span style="color: grey">(eb88c7a)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(8dde763)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(a7e1baf)</span></li>
<li>kio/kio/jobclasses.h <span style="color: grey">(de27f40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106052/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>