<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105973/">http://git.reviewboard.kde.org/r/105973/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2012, 9:05 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch!
I'd say that it looks good code-wise (can't say much about the CMake stuff though, my CMake knowledge is rather limited).
However, I don't think that we should keep track of the locations that a user visits in a hidden place if the user does not ask for it explicitly (I'm thinking about privacy here). Users know nowadays that they leave lots of traces both on their computer and elsewhere when visiting web pages, but I'm afraid that some users might get upset if they find out that we keep a hidden log of folders that have been opened in Dolphin, considering that Dolphin does currently not have a persistent history of visited folders.
But maybe I'm too conservative here, I don't know. Can you provide some information about other info that the activity manager stores without the user's knowledge? Is there a way to disable the logging, and can the user clear the collected data easily?
</pre>
</blockquote>
<p>On August 13th, 2012, 7:57 a.m., <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There will be a KCM for activities in 4.10 where it will be possible to filter out specific applications, or to filter out all logging.
The currently logged things are - when a document (in this case location) is opened and closed. And for how long it had focus. Based on that, the scores are calculated for the (resource, activity) pair.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And, obviously, it will also have the 'clear stats from the last 1, 2, 4 hours / 1 day / clear all'
You can see this as an expansion of the recent documents system (XDG spec) that have been tracking what the user opens since kde 3.x days without the possibility of being configured.
This, if not turned off, would provide a much more usable concept than recent documents do.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On August 11th, 2012, 10:27 a.m., Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 10:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dolphin reports open locations to the activity manager (KAMD).
Reasoning behind the feature:
- KAMD ranks the locations based on the time the user has spent in them
- Share-Like-Connect applet can know what is open in dolphin
This is an compile-time-optional feature - turned on if there is libkactivities installed.
The find_package(KActivities) is located in the root CMakeLists.txt because this feature should also be implemented for Konqueror.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With SDI windows, with tabs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: grey">(31c82d6)</span></li>
<li>dolphin/src/dolphinviewcontainer.h <span style="color: grey">(fd52806)</span></li>
<li>CMakeLists.txt <span style="color: grey">(fab73c1)</span></li>
<li>config-apps.h.cmake <span style="color: grey">(43764ef)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(5c1a6da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105973/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105973/s/672/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/10/dolphin-slc_400x100.jpg" style="border: 1px black solid;" alt="S-L-C showing dolphin folder" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>