<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105603/">http://git.reviewboard.kde.org/r/105603/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 98d4018a36991e017be6d8c963f9ccbb3256d8e0 by Albert Astals Cid to branch frameworks.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 17th, 2012, 11:24 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 11:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's two i didn't do because use isDestroyed and David suggested that'll get into 5.1
In ktimezone i removed the &* which i guess might be needed before but not now what we get a pointer directly
There's more in kdelibs but i just wanted a first review on this to make sure i'm not doing something totally wrong and thus have to redo something.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kdatetime.cpp <span style="color: grey">(9d01afb)</span></li>
<li>kdecore/date/ksystemtimezone.cpp <span style="color: grey">(770e8c8)</span></li>
<li>kdecore/date/ktimezone.cpp <span style="color: grey">(66279a8)</span></li>
<li>kdecore/io/kdebug.cpp <span style="color: grey">(528a68a)</span></li>
<li>kdecore/kernel/ktoolinvocation.h <span style="color: grey">(ad669fd)</span></li>
<li>kdecore/kernel/ktoolinvocation.cpp <span style="color: grey">(af0cecb)</span></li>
<li>kdecore/localization/klocalizedstring.cpp <span style="color: grey">(333ea37)</span></li>
<li>kdecore/services/kmimetypefactory.cpp <span style="color: grey">(8e42169)</span></li>
<li>kdecore/services/kmimetypetrader.h <span style="color: grey">(4267c19)</span></li>
<li>kdecore/services/kmimetypetrader.cpp <span style="color: grey">(bf2274e)</span></li>
<li>kdecore/services/kservicefactory.cpp <span style="color: grey">(7265ca9)</span></li>
<li>kdecore/services/kservicegroupfactory.cpp <span style="color: grey">(79001dd)</span></li>
<li>kdecore/services/kservicetypefactory.cpp <span style="color: grey">(490a05f)</span></li>
<li>kdecore/services/kservicetypeprofile.cpp <span style="color: grey">(0629a8c)</span></li>
<li>kdecore/services/kservicetypetrader.h <span style="color: grey">(f403e9d)</span></li>
<li>kdecore/services/kservicetypetrader.cpp <span style="color: grey">(ac6c0d9)</span></li>
<li>kdecore/sycoca/ksycoca.cpp <span style="color: grey">(5b91377)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105603/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>