<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102038/">http://git.reviewboard.kde.org/r/102038/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI, ksysguard.desktop now uses "KSysGuard" as "Name" and "System Monitor" as "GenericName". See https://git.reviewboard.kde.org/r/105338/. So there is no more valid reason to add the "OnlyShownIn" key for it.
For systemsettings, the problem seems to be "solved" by shipping systemsettings.desktop for KDE environment and kdesystemsettings.desktop for non-KDE environment.
So I think this review can be closed now.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On July 21st, 2011, 10:39 p.m., Jeremy Bicha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Jeremy Bicha.</div>
<p style="color: grey;"><i>Updated July 21, 2011, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add OnlyShowIn:KDE line to KSysguard & SystemSettings. Otherwise, it's very frustrating when running any other desktop (Gnome Shell, Unity, etc.) and seeing multiple apps named the same thing with the same icon without any way to distinguish them.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksysguard/gui/ksysguard.desktop <span style="color: grey">(7e8ff32f1e275ee246e79da039509e28e56987cf)</span></li>
<li>systemsettings/app/systemsettings.desktop <span style="color: grey">(5934a194675cfe152ebdbfd4a9db45ebd48b67a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>