<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105402/">http://git.reviewboard.kde.org/r/105402/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2012, 12:07 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Was this actually asked by packagers? I am no expert, but the feedback I had from a Debian packager working on CMake projects was that he preferred to have all dependencies listed in the top-level CMakeLists.txt.
The reason he gave were:
- It is easier to list all dependencies this way
- It avoids the situation where A/CMakeLists.txt has an optional dependency on package Foo and B/CMakeLists.txt has a mandatory dependency on Foo (possibly added later).</pre>
</blockquote>
<p>On July 3rd, 2012, 12:11 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mmm... I didn't notice you were working on Gentoo. You most likely know more than I do, but still I would be interested to know how this change helps you.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the delay in responding - I ran into an issue where I was not receiving reviewboard mail (since fixed).
In Gentoo, the user will build their package using the original upstream tarballs. So, if the user wishes to build kdesu, our package management system will unpack the required parts of kde-runtime-x.x.x.tar.xz - including the root CMakeLists.txt
If the root CMakeLists.txt contains a dependency, CMake will then of course require that dependency for each and every application contained within the tarball, regardless of whether it's required or not - behaviour that is troublesome for anyone building from source, not just us.
In this case, this change brings us the substantial benefit of not needing to patch (N - 1) applications to remove an unneeded KdepimLibs dependency (where N is however many applications make up kde-runtime).</pre>
<br />
<p>- Michael</p>
<br />
<p>On July 1st, 2012, 4:23 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and George Kiagiadakis.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated July 1, 2012, 4:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves the dependency on KdepimLibs to /drkonqi, since that's the program requiring it.
This is done to assist downstream packaging.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5091890a0768fd553f972a9b113f7f826d63f356)</span></li>
<li>drkonqi/CMakeLists.txt <span style="color: grey">(102185ac52f558fba78cf2da80a1e8a0fe870e18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105402/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>