<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105337/">http://git.reviewboard.kde.org/r/105337/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f4fbf758ce808b524322b4a812f1395f8e97efd7 by Jonathan Marten to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 23rd, 2012, 8:51 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated June 23, 2012, 8:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The referenced bug suggested this option to cover the case where web sites opened new windows (via JS) without user interface elements, if this is the case there is no way to bring back the status bar which can show important information. A patch was posted (http://lists.kde.org/?l=kfm-devel&m=122885401907547&w=2) a long time ago, but it was rejected because Konqueror's handling of the status bar is special (each view has its own status bar) and the patch took no account of that.
Hopefully this updated patch does. The menu option only toggles the status bar of the current view - I did think about making it do the status bars of all of the views simultaneously but was not sure whether this would be the right thing to do. Of course, for a single view in the window, the option does what is expected anyway.
There are GUI changes but no I18N strings (the KStandardAction is used).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built Konqueror with these changes, tested with file management and web browsing profiles with various window splits.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=111162">111162</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqmainwindow.h <span style="color: grey">(1666370)</span></li>
<li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(0b49be5)</span></li>
<li>konqueror/src/konqueror.rc <span style="color: grey">(f788484)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105337/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>