<br><br><div class="gmail_quote">2012/6/23 Lamarque Vieira Souza <span dir="ltr"><<a href="mailto:lamarque@kde.org" target="_blank">lamarque@kde.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105278/" target="_blank">http://git.reviewboard.kde.org/r/105278/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div class="im"><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On June 16th, 2012, 4:15 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table bgcolor="white" border="0" width="100%">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/105278/diff/1/?file=68027#file68027line408" style="text-decoration:underline;font-weight:bold" target="_blank">kdeui/actions/kaction.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">void KAction::setAuthAction(KAuth::Action *action)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#e9eaa8"><font>408</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span><span>//</span>delete d->authAction;</span></pre></td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#e9eaa8"><font>408</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>delete</span> <span>d</span><span>-></span><span>authAction</span><span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that commented this line, but Dario did not give any reason why not delete the action.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I think you should have asked Dario why he did this change in the first place, also you should not commit a patch without a "ship it" from another developer.</pre>
<div class="im">
<br></div></div></div></blockquote><div>Hi, I'm sorry. <br>Saturday was, for me, one of those days where one should stay in bed. Almost everything I did on Saturday was wrong :-(. Yesterday I was in quarantine, I did not touch any computer at all.<br>
I've been using reviewboard in the right way since I did a wrong file svn commit long time ago, except:<br>* last saturday, sigh<br>* trivial commits of prefix ++ vs postfix ++<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div><div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<p>- Lamarque Vieira</p>
<br>
<p>On June 16th, 2012, 3:37 p.m., Jaime Torres Amate wrote:</p>
<table style="background-image:url('');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color:grey"><i>Updated June 16, 2012, 3:37 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid() none.
2. why do not want to delete d->authAction if it is nulled after that.
3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">6 months or more with it locally.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kdecore/date/kcalendarera.cpp <span style="color:grey">(0a21e37)</span></li>
<li>kdeui/actions/kaction.cpp <span style="color:grey">(309cf82)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color:grey">(feb0c9e)</span></li>
<li>sonnet/unicode/parseucd/parseucd.cpp <span style="color:grey">(1c9b90e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105278/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br>