<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105318/">http://git.reviewboard.kde.org/r/105318/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 21st, 2012, 10:05 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually "SMB Shares" ;)
Changing it is not really useful i think. I for example make "Samba shares" between Linux machines as well since that is just easy and why should those be called "Windows Shares" all of a sudden? I think "Samba Shares" is just fine. Perhaps "SMB Shares" describes it even better.
I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not.</pre>
</blockquote>
<p>On June 22nd, 2012, 12:45 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So "SMB Shares" is also not a good name.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Windows a "\\" path is "translated" into a "smb://" URL for KDE apps, so no Samba is used at all but the bookmark is still called "Samba Shares"</pre>
<br />
<p>- Andrius da Costa</p>
<br />
<p>On June 21st, 2012, 3:40 p.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and David Edmundson.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated June 21, 2012, 3:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)'
I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response.
http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2
Since we are past string freeze this is probably for 4.10
I can not commit this myself, thanks</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=141257">141257</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/smb/smb-network.desktop <span style="color: grey">(a121a31)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105318/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>