<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105318/">http://git.reviewboard.kde.org/r/105318/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 21st, 2012, 10:05 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually "SMB Shares" ;)
Changing it is not really useful i think. I for example make "Samba shares" between Linux machines as well since that is just easy and why should those be called "Windows Shares" all of a sudden? I think "Samba Shares" is just fine. Perhaps "SMB Shares" describes it even better.
I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not.</pre>
</blockquote>
<p>On June 22nd, 2012, 12:45 a.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So "SMB Shares" is also not a good name.</pre>
</blockquote>
<p>On June 22nd, 2012, 2:20 a.m., <b>Andrius da Costa Ribas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Windows a "\\" path is "translated" into a "smb://" URL for KDE apps, so no Samba is used at all but the bookmark is still called "Samba Shares"</pre>
</blockquote>
<p>On June 22nd, 2012, 3:24 a.m., <b>Maarten De Meyer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know it uses the SMB protocol, thats why I added it in brackets. We know samba. My mother however thinks about a certain latin dance when I tell her to 'use the samba share'.
I don't know what it is called in other linux DE's and it doesn't matter, we should chose the best fitting string. There are different interpretations of best. For me that means it hides implementation details and is easy to understand for everybody. Other people might want to call it what it is.
SMB would be even worse compared to samba imo, this change is to make it easier for new users, not harder.
Not sure about the trademark, I doubt it would be a problem but am obviously no lawyer.
This is not really an important change, if this is considered bad I'll just close this review and the bug. It was more a personal attempt to get used to bug fixing workflow.</pre>
</blockquote>
<p>On June 22nd, 2012, 4:57 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perhaps it should be called "Network Shares" because that is what they are and makes it more understandable for the non techical people as well. Regardless of SMB, CIFS or whatever protocol is being used.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kcm uses "Windows Shares" as caption and says "...configure which windows (smb) filesystems you can..." which is imo really the worst variant because it's in the context of systemsettings not really clear that it's talking about "MS Windows (tm)" since windows otherwise refer to, well, the windows on your desktop and the exact meaning is not really stressed by using the lowercase variant.
However, i don't like talking about even "MS Windows (tm) shares" because it's rather misleading, given many *nix servers and esp. NAS provide SMB/CIFS
Since the entire concept is rather uniquely done through samba / smb:// i'd rather completely avoid the particular words "samba", "windows" or "shares" (it's too generic, ppl. might think of NYSE) and just talk about "Network folders" as, similar to what Mark said, "that's what they are" - and let me add "unfortunately" :-P
Also there's much blank space in kcm and tooltip available for an explanation that this is SMB/CIFS provided on POSIX systems through Samba (add a link?) and predominantly used by MS Windows to export local paths to the network.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On June 21st, 2012, 3:40 p.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and David Edmundson.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated June 21, 2012, 3:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)'
I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response.
http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2
Since we are past string freeze this is probably for 4.10
I can not commit this myself, thanks</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=141257">141257</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/smb/smb-network.desktop <span style="color: grey">(a121a31)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105318/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>