<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104988/">http://git.reviewboard.kde.org/r/104988/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3faed364339edef012b04db23fea055e7ff26121 by Peter Penz to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 19th, 2012, 6:54 a.m., Hui Ni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps and Peter Penz.</div>
<div>By Hui Ni.</div>
<p style="color: grey;"><i>Updated May 19, 2012, 6:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes dolphin information panel to show a video widget depending on the video content instead of mimetype string.
There are container formats which can be either audios or videos.
Besides, the rmvb video files have mimetype of "application/vnd.rn-realmedia", and these files can be recognized as videos correctly now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with no more regressions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/information/informationpanelcontent.h <span style="color: grey">(1d964f5)</span></li>
<li>dolphin/src/panels/information/informationpanelcontent.cpp <span style="color: grey">(4a96bd1)</span></li>
<li>dolphin/src/panels/information/phononwidget.h <span style="color: grey">(1e1ea37)</span></li>
<li>dolphin/src/panels/information/phononwidget.cpp <span style="color: grey">(5f0c111)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104988/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>