<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104895/">http://git.reviewboard.kde.org/r/104895/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 9th, 2012, 6:30 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ehh optional perhaps?
I've seen forms behave like this before and back then when i first saw it i tried to delete the text.. Which obviously didn't happen. The text just disappears as soon as i start typing. I kinda dislike that behavior. I mean, there is a big fat blue focus border that has the purpose of telling the user that the one with the blue border (style dependent) is the one that currently has focus. The blinking cursor is yet another indication that the field has focus. I think that is enough.
Perhaps optional, but please not by default. This is just my opinion and i don't maintain plasma components (nor anything in KDE for that matter). You'd have to wait for a reply from some of the plasma component maintainers to get a final word on this.</pre>
</blockquote>
<p>On May 10th, 2012, 11:38 a.m., <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This just fixes a race condition, I don't quite understand your reservation, Mark?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No it doesn't. Currently if you give an item focus you hide the placeholder text. In this patch it only hides placeholder text after you start typing.</pre>
<br />
<p>- David</p>
<br />
<p>On May 9th, 2012, 4:53 p.m., Sebastian Gottfried wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Sebastian Gottfried.</div>
<p style="color: grey;"><i>Updated May 9, 2012, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rationale: This allows the application to pre-focus a text field with a
placeholder text for the user. In the version before this would have
hidden the placeholder text and it may not have been obvious for user
what he was expected to enter in the text field.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used it in ktouch/next, works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/TextArea.qml <span style="color: grey">(2d9e89f)</span></li>
<li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: grey">(4ed15d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104895/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104895/s/562/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/09/placeholder-with-focus_400x100.png" style="border: 1px black solid;" alt="Form in KTouch" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>