<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104821/">http://git.reviewboard.kde.org/r/104821/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bb5ef71483caaf1ce9cd2d4aa50a43583531cc1c by Sebastian Kügler to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 3rd, 2012, 4:19 p.m., Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Dawit Alemayehu.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 3, 2012, 4:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make htmlcreator thumbnailer plugin support remote URLs
Requesting thumbnails for URLs has been added to kdelibs in 4.7. This patch makes the webcreator thumbnailer plugin support remote URLs as well.
We've been using a similar webcreator in Plasma Active, with this patch, our use cases would be covered by stock KDE.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used plugin through Plasma's preview engine for URLs, thumbnails of local html files also still work (tested through Dolphin).
I'm getting all-white images sometimes, the check for mainFrame()'s contentSize() mitigates this partly, but it still happens. As that's not a regression for local code, I'd like to get this patch merged. (When the error happens, loadFinished() still returns true, so it isn't caught by the m_loadedOk guard.) If anyone has suggestions how to handle these kinds of "silent failures", they would be most welcome :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/thumbnail/htmlcreator.cpp <span style="color: grey">(afbcea2)</span></li>
<li>kioslave/thumbnail/htmlthumbnail.desktop <span style="color: grey">(9cc4e02)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104821/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104821/s/554/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/02/bookmarks-webpreviews_400x100.png" style="border: 1px black solid;" alt="previews for bookmarks" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>