<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101463/">http://git.reviewboard.kde.org/r/101463/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 29th, 2011, 1:05 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure wheher it's really worth it (though using ARGB over XShape might actually bring better performance) but I assume the style (oxygen) can deal this more efficiently (via polishment) and also globally (not only for the folderview plasmoid but _all_ Qt icon drags)
Gonna try and send Hugo a "patch" if it works.</pre>
</blockquote>
<p>On May 29th, 2011, 1:29 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, is. As trivial as
if (widget->testAttribute(Qt::WA_X11NetWmWindowTypeDND) && FX::compositingActive()) // uses KWindowSystem, FX is bespin
{
widget->setAttribute(Qt::WA_TranslucentBackground);
widget->clearMask();
}</pre>
</blockquote>
<p>On May 29th, 2011, 3:16 p.m., <b>Mathias Stephan Panzenböck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you have *a lot* of desktop icons and drag them all, the current code (using a mask and no ARGB window) makes kwin so slow, that the automatic desktop effects deactivation kicks in. So I think just for that it is worth to apply this (or a similar) patch. Also I think using these masked icons are really ugly. If no ARGB window can be used it would be better to use drag icons like dolphin does.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with Thomas it would be much less of a hack if it goes in the style.
Will add in there.
(PS: I see other places where I'd love ARGB in DND, namely when moving title windows around for "window tabbing").</pre>
<br />
<p>- Hugo</p>
<br />
<p>On April 19th, 2012, 11:29 p.m., Mathias Stephan Panzenböck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Mathias Stephan Panzenböck.</div>
<p style="color: grey;"><i>Updated April 19, 2012, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine.
The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows:
http://bugreports.qt.nokia.com/browse/QTBUG-8519</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=256475">256475</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/iconview.h <span style="color: grey">(e648ff0)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: grey">(3186b18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>