<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104785/">http://git.reviewboard.kde.org/r/104785/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2012, 7:56 p.m., <b>Konstantinos Smanis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104785/diff/1/?file=59459#file59459line41" style="color: black; font-weight: bold; text-decoration: underline;">kio/bookmarks/kbookmarkdombuilder.cc</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KBookmarkDomBuilder::KBookmarkDomBuilder(</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">importer</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">newFolder</span><span class="p">(</span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">QString</span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt"><span class="hl">bool</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">QString</span><span class="hl"> </span><span class="o"><span class="hl">&</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">importer</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">newFolder</span><span class="p">(</span><span class="n">QString</span><span class="p"><span class="hl">,</span></span><span class="n">QString</span><span class="p"><span class="hl">,</span></span><span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">)</span>),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You change the signature here (second argument: bool->QString)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wow, well spotted. Dawit, don't you use a script, to normalize signatures? I thought the Qt developers had one.
If there's no such script, I'm against making such changes in the future, it's just too dangerous, for very little gain. If Konstantinos hadn't spotted this, we would have a nice runtime-only bug now...</pre>
<br />
<p>- David</p>
<br />
<p>On April 29th, 2012, 8:22 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 8:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following patch fixes the following krazy2 warnings:
- Use const references in Q_FOREACH statements where appropriate.
- Normalize yet more signal/slot connections (missing from the first go round).
- Use brackets instead of double-quotes for the 'config*' header files.
- Fix the #ifdef statements in header files to reflect the header filename.
I did this a long time ago, but never pushed upstream. As part of my spring clean up I want to push this local changes upstream. Any objections ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkdialog.cc <span style="color: grey">(713ceff)</span></li>
<li>kio/bookmarks/kbookmarkdombuilder.cc <span style="color: grey">(8e0be3c)</span></li>
<li>kio/bookmarks/kbookmarkimporter.cc <span style="color: grey">(08210f7)</span></li>
<li>kio/bookmarks/kbookmarkmanager.cc <span style="color: grey">(d8a9cb7)</span></li>
<li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">(deb973b)</span></li>
<li>kio/bookmarks/konqbookmarkmenu.cc <span style="color: grey">(4fc6be0)</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: grey">(8caa0c2)</span></li>
<li>kio/kfile/kfilemetadataprovider_p.h <span style="color: grey">(09d924a)</span></li>
<li>kio/kfile/kfilemetadatareaderprocess.cpp <span style="color: grey">(5103087)</span></li>
<li>kio/kfile/kimagefilepreview.cpp <span style="color: grey">(74ef8b7)</span></li>
<li>kio/kio/chmodjob.cpp <span style="color: grey">(85e0c2c)</span></li>
<li>kio/kio/job.h <span style="color: grey">(aeaffa2)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(5e18998)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
<li>kio/kio/kdesktopfileactions.cpp <span style="color: grey">(edf2e9c)</span></li>
<li>kio/kio/kfileitemactions.h <span style="color: grey">(27ab4e3)</span></li>
<li>kio/kio/kfileitemactions.cpp <span style="color: grey">(c79a434)</span></li>
<li>kio/kio/kfilemetainfoitem.cpp <span style="color: grey">(1cab458)</span></li>
<li>kio/kio/ksambasharedata.cpp <span style="color: grey">(aebcb04)</span></li>
<li>kio/kio/kurifilter.h <span style="color: grey">(289b910)</span></li>
<li>kio/kio/kurifilter.cpp <span style="color: grey">(0144a2c)</span></li>
<li>kio/kio/renamedialog.cpp <span style="color: grey">(11e55a9)</span></li>
<li>kio/misc/kpac/proxyscout.cpp <span style="color: grey">(0068ce7)</span></li>
<li>kio/misc/kpac/script.cpp <span style="color: grey">(a595301)</span></li>
<li>nepomuk/core/resourcedata.cpp <span style="color: grey">(d6b0121)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104785/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>