<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104351/">http://git.reviewboard.kde.org/r/104351/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 30th, 2012, 8:41 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks ok, but probably needs rebasing, the code in ProtoQueue::removeJob(SimpleJob *job) looks very different here.
(I think checking for job being null is overzealous)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm... It applies just fine here on the 4.8 branch and I do not have any other local changes in scheduler.cpp. No idea what that might. As far as the check for job being NULL might indeed be a bit overzealous, but I was simply following the same thing that was done in the else statement right below that code. Well at least that is my story and I am sticking to it. ;)</pre>
<br />
<p>- Dawit</p>
<br />
<p>On March 20th, 2012, 7:14 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated March 20, 2012, 7:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch sets the top level window that should be used when displaying message boxes in KIO::SlaveInterface. This is the first step into eliminating those multiple message boxes that are popped up because of the out-process design of KIO. Note that this is not the actual resolution, but the first step.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/scheduler.cpp <span style="color: grey">(8d144bb)</span></li>
<li>kio/kio/slaveinterface.h <span style="color: grey">(3cdc2ae)</span></li>
<li>kio/kio/slaveinterface.cpp <span style="color: grey">(d2f9f93)</span></li>
<li>kio/kio/slaveinterface_p.h <span style="color: grey">(e2ccfe0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104351/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>