<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104599/">http://git.reviewboard.kde.org/r/104599/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 192b43ce1f6a474564f4cc0be20f97a5fa53fc5a by David Jarvie to branch KDE/4.8.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 14th, 2012, 7:30 p.m., David Jarvie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated April 14, 2012, 7:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTzfileTimeZone, and therefore time zones provided by KSystemTimeZones, returns the wrong time zone abbreviation for dates earlier than the start of time zone data in the time zone configuration file. This patch fixes that, but requires a new variant of the setPhases() method to be added to KTimeZone. The existing variant of setPhases() will be marked as deprecated. Note that this method is only for use by classes derived from KTimeZone, so the number of users of these methods will be very limited (as far as I know, only ICalTimeZone in kdepimlibs).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTimeZone unit test now works after removing the temporary bodge put in because of this bug.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/ktimezone.h <span style="color: grey">(f591747)</span></li>
<li>kdecore/date/ktimezone.cpp <span style="color: grey">(076d459)</span></li>
<li>kdecore/date/ktzfiletimezone.cpp <span style="color: grey">(1ebca9d)</span></li>
<li>kdecore/tests/ktimezonestest.cpp <span style="color: grey">(3a2402e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104599/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>