<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104511/">http://git.reviewboard.kde.org/r/104511/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please fix the inlining thing.
I am also not sure about the repetition of the default value for 3rd argument for getOwnPropertyNames all over the place. May be just drop the default
argument entirely? That would have the bonus of making sure that the call is it right everywhere. (For example for the call inside the debugger it might actually be handy to include DontEnum properties as well..)
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104511/diff/5/?file=58267#file58267line655" style="color: black; font-weight: bold; text-decoration: underline;">kjs/property_map.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool PropertyMap::containsGettersOrSetters() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">655</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">PropertyMap</span><span class="o">::</span><span class="n">getEnumerablePropertyNames</span><span class="p">(</span><span class="n">PropertyNameArray</span><span class="o">&</span> <span class="n">propertyNames</span><span class="p">)</span> <span class="k">const</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">655</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span class="n">PropertyMap</span><span class="o">::</span><span class="n">checkEnumerable</span><span class="p">(</span><span class="kt">unsigned</span> <span class="kt">int</span> <span class="n">attr</span><span class="p">,</span> <span class="n">PropertyMap</span><span class="o">::</span><span class="n">PropertyMode</span> <span class="n">mode</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This needs to be inline in the header file.
</pre>
</div>
<br />
<p>- Maks</p>
<br />
<p>On April 20th, 2012, 11:48 a.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated April 20, 2012, 11:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames
NOTE: Array was left out on purpose, as currentl imeplementation does not save attributes (next patch will fix this)
keys&GetOwnPropertyNames requieres to change the JSObject::getOwnPropertyNames implementation,
for future use a enum is better than than a bool, maybe there will be more ways to include/exclude properties.
All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ecma script & daily surfing</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/kjs_css.h <span style="color: grey">(aba44b8)</span></li>
<li>khtml/ecma/kjs_css.cpp <span style="color: grey">(e3e7417)</span></li>
<li>khtml/ecma/kjs_dom.h <span style="color: grey">(d0433c3)</span></li>
<li>khtml/ecma/kjs_dom.cpp <span style="color: grey">(5fff7e3)</span></li>
<li>khtml/ecma/kjs_html.h <span style="color: grey">(0f3f544c)</span></li>
<li>khtml/ecma/kjs_html.cpp <span style="color: grey">(e3da95c)</span></li>
<li>khtml/ecma/kjs_scriptable.h <span style="color: grey">(af5343c)</span></li>
<li>khtml/ecma/kjs_scriptable.cpp <span style="color: grey">(5d4ea68)</span></li>
<li>kjs/JSVariableObject.h <span style="color: grey">(a8f01eb)</span></li>
<li>kjs/JSVariableObject.cpp <span style="color: grey">(b00ef76)</span></li>
<li>kjs/array_instance.h <span style="color: grey">(3f2b630)</span></li>
<li>kjs/array_instance.cpp <span style="color: grey">(fe9b8b4)</span></li>
<li>kjs/function.h <span style="color: grey">(3757fe8)</span></li>
<li>kjs/function.cpp <span style="color: grey">(5f39ae6)</span></li>
<li>kjs/object.h <span style="color: grey">(047c242)</span></li>
<li>kjs/object.cpp <span style="color: grey">(c19122f)</span></li>
<li>kjs/object_object.cpp <span style="color: grey">(986f03f)</span></li>
<li>kjs/property_map.h <span style="color: grey">(6b127ff)</span></li>
<li>kjs/property_map.cpp <span style="color: grey">(b2ff08e)</span></li>
<li>kjs/string_object.h <span style="color: grey">(e890d52)</span></li>
<li>kjs/string_object.cpp <span style="color: grey">(170e2f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104511/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>